Re: [PATCH] kbuild: do not check for ancient modutils tools

From: Kay Sievers
Date: Fri Jan 20 2012 - 11:41:20 EST


On Wed, Jan 18, 2012 at 05:33, Cong Wang <amwang@xxxxxxxxxx> wrote:
> On Tue, 2012-01-17 at 14:50 -0200, Lucas De Marchi wrote:
>> scripts/depmod.sh checks for the output of '-V' expecting that it has
>> module-init-tools in it. It's a hack to prevent users from using
>> modutils instead of module-init-tools, that only works with 2.4.x
>> kernels. This however prints an annoying warning for kmod tool, that is
>> currently replacing module-init-tools.
>>
>> Rather than putting another check for kmod's version, just remove it
>> since users of 2.4.x kernel are unlikely to upgrade to 3.x, and if they
>> do, let depmod fail in that case because they should know what they are
>> doing.
>>
>> Signed-off-by: Lucas De Marchi <lucas.demarchi@xxxxxxxxxxxxxx>
>
> Acked-by: WANG Cong <amwang@xxxxxxxxxx>

Michal, mind picking this up? The warning it produces with kmod is
really misleading, and the check seems unnecessary these days.

Acked-By: Kay Sievers <kay.sievers@xxxxxxxx>

Thanks,
Kay
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/