Re: [RFC] fs, proc: Introduce /proc/<pid>/task/<tid>/children entryv6

[Cyrill Gorcunov]

On Thu, Jan 19, 2012 at 05:44:13PM +0100, Oleg Nesterov wrote:
> On 01/19, Cyrill Gorcunov wrote:
> >
> > On Thu, Jan 19, 2012 at 04:55:29PM +0100, Oleg Nesterov wrote:
> > >
> > > Thinking more... I am not sure, but do we really need
> > > proc_pid_children_iter at all??
> > >
> > > It is very possibly I missed something, but we can get both
> > > parent_pid and pid_ns from inode, right? so can't we just remember
> > > inode in seq->private?
> >
> > Good point. Letme check if we will need to call for ihold then...
> > (/me scratchig the head)
> 
> Why? file/inode can't go away, at least until this fd is closed.
> 
> And just in case, get_pid(proc_pid(inode)) is not needed, even in v6/v7.
> I didn't realize this.
> 

Grr, indeed.

> Cyrill, I won't argue if you prefer to make this in a separate patch
> (of course, assuming you are agree) on top of v7, to me it looks
> "good enough".
> 

I think better to make completely updated version then, than pushing
changes on top. it'll be better to put anything in one patch I think.

Thanks!

	Cyrill
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/