Re: [PATCH 1/6] staging:android_pmem.h: Fixes the space and otherformating issues pointed out by checkpatch.pl

[Dan Carpenter]

On Wed, Jan 18, 2012 at 11:38:34PM +0530, Pradheep Shrinivasan wrote:
>> > > -#define PMEM_IOCTL_MAGIC 'p'
> > > +#define PMEM_IOCTL_MAGIC ('p')
> >
> > You don't need parenthesis here.  Did checkpatch really complain
> > about this?
>
> Yes the check patch does complain about the parenthesis.
> 
> pradheep@ubuntu:~/linux-next/
> linux-next/drivers/staging/android$ checkpatch android_pmem.h
> android_pmem.h:10: ERROR: trailing whitespace
> android_pmem.h:19: ERROR: Macros with complex values should be enclosed in
> parenthesis

That seems like a bug in checkpatch.pl.  It's hard to imagine less
complex macro than:  #define PMEM_IOCTL_MAGIC 'p'

Perhaps if the check looked for one of these characters: */+-=<>|&

regards,
dan carpenter

Attachment: signature.asc
Description: Digital signature