Re: [Update][PATCH] PM / Hibernate: Fix s2disk regression relatedto unlock_system_sleep()

[Tejun Heo]

On Wed, Jan 18, 2012 at 09:30:37AM -0800, Tejun Heo wrote:
> Hello, Srivatsa.
> 
> On Wed, Jan 18, 2012 at 10:49:09PM +0530, Srivatsa S. Bhat wrote:
> > I agree, but I was trying to keep the comment from growing too long ;)
> 
> It doesn't have to be long.  It just has to give some meaning to the
> decision.  AFAICS, it is correct to call try_to_freeze() on
> unlock_system_sleep() regardless of 20sec window.  There's no
> guarantee the unlocking task is gonna hit try_to_freeze() elsewhere
> and not calling it actually makes the interface buggy.

To give an example,

	/*
	 * XXX: Open code SKIP clearing for now to avoid invoking
	 * try_to_freeze().  This isn't correct but this function is
	 * called from deep inside hibernation path and calling
	 * try_to_freeze() leads to hang during hibernation.  This
	 * will be properly fixed soon.  See commit message for
	 * more details.
	 */

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/