Re: [PATCH 06/07] LEDS: LED module for DA9052/53 PMIC

[Mark Brown]

On Tue, Jan 17, 2012 at 06:58:24PM +0530, Ashish Jangam wrote:

> +	error = da9052_reg_write(led->da9052, led_reg[led->led_index],
> +				 led->brightness | DA9052_LED_CONT_DIM);

The device has 8 bit registers but brightness could be any 8 bit number
by default (and the driver doesn't set a maxmimum brightness that I
noticed).

> +static int __init da9052_led_init(void)
> +{
> +	return platform_driver_register(&da9052_led_driver);
> +}
> +module_init(da9052_led_init);
> +
> +static void __exit da9052_led_exit(void)
> +{
> +	platform_driver_unregister(&da9052_led_driver);
> +}
> +module_exit(da9052_led_exit);

Use module_platform_driver()
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/