Re: [PATCH] vsprintf: Prevent NULL dereference using %pNF

[Michał Mirosław]

On Tue, Jan 17, 2012 at 10:51:13AM -0800, Joe Perches wrote:
> On Tue, 2012-01-17 at 13:46 -0500, David Miller wrote:
> > From: Joe Perches <joe@xxxxxxxxxxx>
> > Date: Tue, 17 Jan 2012 10:37:13 -0800
> > > Passing NULL to %pNF is done in skb_gso_segment
> > > which could be dereferenced.
> > skb_gso_segment() should be fixed instead.
> Maybe.  Dereferencing NULL is bad form.
> Michał Mirosław should fix that as it's his patch.

Will do. This is in WARN() and easily fixed.

> noinline_for_stack should be added anyway.

Why? There are no local variables there and inlining this function would
actually save stack space as no stack frame would be created for the call.

Best Regards,
Michał Mirosław
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/