Re: [PATCH] vsprintf: Prevent NULL dereference using %pNF

From: David Miller
Date: Tue Jan 17 2012 - 13:52:31 EST


From: Joe Perches <joe@xxxxxxxxxxx>
Date: Tue, 17 Jan 2012 10:51:13 -0800

> On Tue, 2012-01-17 at 13:46 -0500, David Miller wrote:
>> From: Joe Perches <joe@xxxxxxxxxxx>
>> Date: Tue, 17 Jan 2012 10:37:13 -0800
>> > Passing NULL to %pNF is done in skb_gso_segment
>> > which could be dereferenced.
>> skb_gso_segment() should be fixed instead.
>
> Maybe. Dereferencing NULL is bad form.

We don't check for NULL for IPV4 or IPV6 addresses, no reason
to treat this any differently.

Either do it for all %pX things, or none of them.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/