RE: [PATCH] clarify WARNING: at fs/sysfs/dir.c:481 sysfs_add

From: Jason Dravet
Date: Mon Jan 16 2012 - 16:28:22 EST



> > This patch makes it clear that the problem is in the BIOS of
the computer and not the kernel.  This patch applies to kernel 3.2.1.
> >
> > --- dir.orig    2012-01-14 18:58:20.026745884 -0600
> > +++ dir.c    2012-01-14 19:52:33.011444581 -0600
> > @@ -479,6 +479,8 @@ int sysfs_add_one(struct sysfs_addrm_cxt
> >               (path == NULL) ? sd->s_name :
> >               strcat(strcat(sysfs_pathname(acxt->parent_sd, path), "/"),
> >                      sd->s_name));
> > +        WARN(1, KERN_WARNING
> > +             "Your BIOS is broken.  Please contact your computer manufacturer.");
> >          kfree(path);
> >      }
>
> That certainly isn't always the case. Incorrectly written drivers
> have also taken this codepath before now.
>
> Dave

Then how do you tell when the problem is the BIOS or a driver?
Jason --
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/