Re: [PATCH] watchdog: via_wdt: Staticise wdt_pci_table

From: Marc Vertes
Date: Mon Jan 16 2012 - 05:28:15 EST


Axel Lin wrote:

> It is only used in this driver, so no need to make the symbol global.
>

Agree.

Acked-by: Marc Vertes <marc.vertes@xxxxxxxxxx>

> Signed-off-by: Axel Lin <axel.lin@xxxxxxxxx>
> ---
> drivers/watchdog/via_wdt.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/watchdog/via_wdt.c b/drivers/watchdog/via_wdt.c
> index 026b4bb..8b24b00 100644
> --- a/drivers/watchdog/via_wdt.c
> +++ b/drivers/watchdog/via_wdt.c
> @@ -233,7 +233,7 @@ static void __devexit wdt_remove(struct pci_dev *pdev)
> pci_disable_device(pdev);
> }
>
> -DEFINE_PCI_DEVICE_TABLE(wdt_pci_table) = {
> +static DEFINE_PCI_DEVICE_TABLE(wdt_pci_table) = {
> { PCI_DEVICE(PCI_VENDOR_ID_VIA, PCI_DEVICE_ID_VIA_CX700) },
> { PCI_DEVICE(PCI_VENDOR_ID_VIA, PCI_DEVICE_ID_VIA_VX800) },
> { PCI_DEVICE(PCI_VENDOR_ID_VIA, PCI_DEVICE_ID_VIA_VX855) },


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/