Re: linux-next: build failure after merge of the final tree (nettree related)

From: Glauber Costa
Date: Mon Jan 16 2012 - 02:37:08 EST


On 01/09/2012 10:52 AM, David Miller wrote:
From: Stephen Rothwell<sfr@xxxxxxxxxxxxxxxx>
Date: Mon, 9 Jan 2012 16:38:12 +1100

I applied the following patch for today:

From: Stephen Rothwell<sfr@xxxxxxxxxxxxxxxx>
Date: Mon, 9 Jan 2012 16:33:16 +1100
Subject: [PATCH] net: sk_update_clone is only used in net/core/sock.c

so move it there. Fixes build errors when CONFIG_INET is not defeined:

In file included from include/linux/tcp.h:211:0,
from include/linux/ipv6.h:221,
from include/net/ipv6.h:16,
from include/linux/sunrpc/clnt.h:26,
from include/linux/nfs_fs.h:50,
from init/do_mounts.c:20:
include/net/sock.h: In function 'sk_update_clone':
include/net/sock.h:1109:3: error: implicit declaration of function 'sock_update_memcg' [-Werror=implicit-function-declaration]

Signed-off-by: Stephen Rothwell<sfr@xxxxxxxxxxxxxxxx>

Applied, thanks Stephen.
This is not the proper fix.
Although it can stay for a matter of style if you guys prefer the inline function definition to live in sock.c since no one else uses it.
I'll send a patch to fix this, that can live ontop of yours, shortly.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/