Re: [PATCH 2/6] thp: optimize away unnecessary page table locking

[Hillf Danton]

On Fri, Jan 13, 2012 at 11:14 PM, Naoya Horiguchi
<n-horiguchi@xxxxxxxxxxxxx> wrote:
> Hi Hillf,
>
> (1/13/2012 7:04), Hillf Danton wrote:
> [...]
>>> +/*
>>> + * Returns 1 if a given pmd is mapping a thp and stable (not under splitting.)
>>> + * Returns 0 otherwise. Note that if it returns 1, this routine returns without
>>> + * unlocking page table locks. So callers must unlock them.
>>> + */
>>> +int pmd_trans_huge_stable(pmd_t *pmd, struct vm_area_struct *vma)
>>> +{
>>> + Â Â Â VM_BUG_ON(!rwsem_is_locked(&vma->vm_mm->mmap_sem));
>>> +
>>> + Â Â Â if (!pmd_trans_huge(*pmd))
>>> + Â Â Â Â Â Â Â return 0;
>>> +
>>> + Â Â Â spin_lock(&vma->vm_mm->page_table_lock);
>>> + Â Â Â if (likely(pmd_trans_huge(*pmd))) {
>>> + Â Â Â Â Â Â Â if (pmd_trans_splitting(*pmd)) {
>>> + Â Â Â Â Â Â Â Â Â Â Â spin_unlock(&vma->vm_mm->page_table_lock);
>>> + Â Â Â Â Â Â Â Â Â Â Â wait_split_huge_page(vma->anon_vma, pmd);
>>> + Â Â Â Â Â Â Â Â Â Â Â return 0;
>>> + Â Â Â Â Â Â Â } else {
>>
>> Â Â Â Â Â Â Â Â Â Â Â Â Â Â spin_unlock(&vma->vm_mm->page_table_lock); Â Â yes?
>
> No. Unlocking is supposed to be done by the caller as commented.
>
Thanks for correcting /Hillf
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/