Re: [PATCH 6/9] block: add block_touch_buffer tracepoint

From: Tejun Heo
Date: Wed Jan 11 2012 - 12:58:26 EST


On Wed, Jan 11, 2012 at 12:42:01PM -0500, Steven Rostedt wrote:
> On Tue, 2012-01-10 at 10:28 -0800, Tejun Heo wrote:
> >
> > #define CREATE_TRACE_POINTS
> > #include <trace/events/block.h>
> > diff --git a/include/linux/buffer_head.h b/include/linux/buffer_head.h
> > index 458f497..245caed 100644
> > --- a/include/linux/buffer_head.h
> > +++ b/include/linux/buffer_head.h
> > @@ -13,6 +13,7 @@
> > #include <linux/pagemap.h>
> > #include <linux/wait.h>
> > #include <linux/atomic.h>
> > +#include <trace/events/block.h>
>
> trace/events/x.h in a header can cause issue if this header is ever
> included in another trace/events/x.h header. I think I'll need to write
> a patch that allows this, but it wont be pretty.

Hmmm... I see. I'll make touch_buffer() a function.

Thanks.

--
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/