Re: [PATCH v6 7/8] mm: only IPI CPUs to drain local pages if theyexist

From: Michal Nazarewicz
Date: Tue Jan 10 2012 - 07:49:17 EST


2012/1/9 Michal Nazarewicz <mina86@xxxxxxxxxx>:
This is initialised in setup_per_cpu_pageset() so it needs to be file
scoped.

On Tue, 10 Jan 2012 13:43:21 +0100, Gilad Ben-Yossef <gilad@xxxxxxxxxxxxx> wrote:
Yes. The cpumask_var_t abstraction is convenient and all but it does
make the allocation very non obvious when it does not happen in
proximity to the variable use - it doesn't *look* like a pointer.

You can say that about any file scoped variable that needs non-const
initialisation, not only pointers.

--
Best regards, _ _
.o. | Liege of Serenely Enlightened Majesty of o' \,=./ `o
..o | Computer Science, MichaÅ âmina86â Nazarewicz (o o)
ooo +----<email/xmpp: mpn@xxxxxxxxxx>--------------ooO--(_)--Ooo--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/