Re: Checkpatch possible false positive

From: Andy Whitcroft
Date: Thu Jan 05 2012 - 14:21:31 EST


On Thu, Dec 22, 2011 at 07:39:29PM +0100, Marco Navarra wrote:
> Hello
>
> after running checkpatch on some files, it returns "ERROR: Macros with
> complex values should be enclosed in parenthesis" while processing
> code like this:
> #define SOMEVALUE 'x'
>
> It happens on agpgart.h, checkpatch complains about line 30 that
> corresponds to:
> #define AGPIOC_BASE 'A'
> Running it on elf.h returns the same error on these lines
> #define ELFMAG1 'E'
> #define ELFMAG2 'L'
> #define ELFMAG3 'F'
>
> Do you think this could be a false positive?
> The tree is linux-next and checkaptch version is 0.32

It does seem likley this is something which can be without ()'s. I will
see if we can stop it being picked up.

-apw
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/