Re: [PATCH 2/2] time: remove the unnecessaryCONFIG_GENERIC_CLOCKEVENS check

[Paul Bolle]

On Thu, 2012-01-05 at 21:28 +0800, Feng Tang wrote:
> In kernel/time/Kconfig:
> config GENERIC_CLOCKEVENTS_BUILD
> 	bool
> 	default y
> 	depends on GENERIC_CLOCKEVENTS
> 
> So there is no need to check CONFIG_GENERIC_CLOCKEVENTS if the
> CONFIG_GENERIC_CLOCKEVENTS_BUILD is defined already.

This is only true because nothing selects GENERIC_CLOCKEVENTS_BUILD
directly, isn't it? So if we're being strict the patch explanation
should mention that.

(Maybe it's even better to simply state
    There is no need to check CONFIG_GENERIC_CLOCKEVENTS if
    CONFIG_GENERIC_CLOCKEVENTS_BUILD is defined.

    This prepares [...]

as that would tell us just enough.)

> This prepares for the total removal of GENERIC_CLOCKEVENTS_BUILD.


Paul Bolle

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/