Re: [PATCH 1/2] remoteproc: depend on EXPERIMENTAL

[Ohad Ben-Cohen]

On Wed, Dec 21, 2011 at 1:21 PM, Ohad Ben-Cohen <ohad@xxxxxxxxxx> wrote:
> Remoteproc is still under development and as it gets traction we
> definitely expect to have some changes in the binary format (most probably
> only in the resource table, e.g. the upcoming move to TLV-based entries).
>
> Active testing and use of remoteproc is most welcome, but we don't want
> users to expect backward binary compatibility with the preliminary
> images we have today.
>
> Therefore mark remoteproc as EXPERIMENTAL, and explicitly inform the user
> about this when a new remote processor is registered.

Applied both patches.

>
> Signed-off-by: Ohad Ben-Cohen <ohad@xxxxxxxxxx>
> Cc: Stephen Boyd <sboyd@xxxxxxxxxxxxxx>
> Cc: Rob Clark <rob@xxxxxx>
> Cc: Mark Grosen <mgrosen@xxxxxx>
> Cc: Ludovic BARRE <ludovic.barre@xxxxxxxxxxxxxx>
> ---
>  drivers/remoteproc/Kconfig           |    3 ++-
>  drivers/remoteproc/remoteproc_core.c |    3 +++
>  2 files changed, 5 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/remoteproc/Kconfig b/drivers/remoteproc/Kconfig
> index 00fb72f..25fc4cc 100644
> --- a/drivers/remoteproc/Kconfig
> +++ b/drivers/remoteproc/Kconfig
> @@ -1,8 +1,9 @@
> -menu "Remoteproc drivers"
> +menu "Remoteproc drivers (EXPERIMENTAL)"
>
>  # REMOTEPROC gets selected by whoever wants it
>  config REMOTEPROC
>        tristate
> +       depends on EXPERIMENTAL
>
>  config OMAP_REMOTEPROC
>        tristate "OMAP remoteproc support"
> diff --git a/drivers/remoteproc/remoteproc_core.c b/drivers/remoteproc/remoteproc_core.c
> index f2354ce..6212b82 100644
> --- a/drivers/remoteproc/remoteproc_core.c
> +++ b/drivers/remoteproc/remoteproc_core.c
> @@ -1275,6 +1275,9 @@ int rproc_register(struct rproc *rproc)
>
>        dev_info(rproc->dev, "%s is available\n", rproc->name);
>
> +       dev_info(dev, "Note: remoteproc is still under development and considered experimental.\n");
> +       dev_info(dev, "THE BINARY FORMAT IS NOT YET FINALIZED, and backward compatibility isn't yet guaranteed.\n");
> +
>        /* create debugfs entries */
>        rproc_create_debug_dir(rproc);
>
> --
> 1.7.5.4
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/