Re: [PATCH] regulator: add regulator_force_disable() definition for!CONFIG_REGULATOR

From: Mark Brown
Date: Mon Jan 02 2012 - 06:40:53 EST


On Mon, Jan 02, 2012 at 06:49:32PM +0900, MyungJoo Ham wrote:
> regulator_force_disable() was omitted in consumer.h for
> !CONFIG_REGULATOR case.

Applied, thanks.

> +static inline int regulator_force_disable(struct regulator *regulator)
> +{
> + return 0;
> +}
> +

I do think this'd be better returning an error - unlike the other stub
functions ignoring the attempt to force disable isn't within the bounds
of normal behaviour and if the consumer is trying to force disable at
all it's probably pretty urgent that the disable actually happens.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/