Re: [27/27] clockevents: Set noop handler inclockevents_exchange_device()

[Jonathan Nieder]

Hi Greg,

Greg KH wrote:

> 2.6.32-longterm review patch.  If anyone has any objections, please let me know.
>
> ------------------
>
> From: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
>
> commit de28f25e8244c7353abed8de0c7792f5f883588c upstream.
[...]
> --- a/kernel/time/clockevents.c
> +++ b/kernel/time/clockevents.c
> @@ -221,6 +221,7 @@ void clockevents_exchange_device(struct
>  	 * released list and do a notify add later.
>  	 */
>  	if (old) {
> +		old->event_handler = clockevents_handle_noop;
>  		clockevents_set_mode(old, CLOCK_EVT_MODE_UNUSED);

This is basically the reverse of 7c1e768974 (clockevents: prevent
clockevent event_handler ending up handler_noop, 2008-09-03).  The
rationale for the latter still applies.  People have been reporting
the analagous patch to this one causing hangs on resume in 3.1.y and
3.2 release candidates:

 - http://thread.gmane.org/gmane.linux.kernel/1233033
 - http://thread.gmane.org/gmane.linux.kernel/1233389
 - http://thread.gmane.org/gmane.linux.kernel/1233159
 - http://thread.gmane.org/gmane.linux.kernel/1227868/focus=1230877

So please consider reverting it for now.

Thanks,
Jonathan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/