RE: [PATCH 2/2] TPS65217: Add tps65217 regulator driver

[AnilKumar, Chimata]

Hi Mark,

On Wed, Dec 28, 2011 at 17:06:02, Mark Brown wrote:
> On Wed, Dec 28, 2011 at 09:14:31AM +0000, AnilKumar, Chimata wrote:
> > On Fri, Dec 23, 2011 at 16:45:39, Mark Brown wrote:
> > > On Fri, Dec 23, 2011 at 10:51:36AM +0530, AnilKumar Ch wrote:
> 
> > > > +/* Supported voltage values for regulators (in milliVolts) */
> > > > +static const u16 VDCDC1_VSEL_table[] = {
> > > > +	900, 925, 950, 975,
> > > > +	1000, 1025, 1050, 1075,
> > > > +	1100, 1125, 1150, 1175,
> > > > +	1200, 1225, 1250, 1275,
> > > > +	1300, 1325, 1350, 1375,
> > > > +	1400, 1425, 1450, 1475,
> > > > +	1500, 1550, 1600, 1650,
> > > > +	1700, 1750, 1800,
> > > > +};
> 
> > > You should replace all these vsel tables with calculations in the code,
> > > they're all regular steps and some of the tables are getting a bit
> > > large.
> 
> > TPS65217 don't have any formula for computing the next voltage value. In
> > entire voltage scale range there is an inconsistency in the step size.
> 
> if (voltage < 1500)
> 	...
> else
> 	...

Changed to functions instead of tables

> 
> > > > +	for (vsel = 0; vsel < tps->info[dcdc]->table_len; vsel++) {
> > > > +		int mV = tps->info[dcdc]->table[vsel];
> > > > +		int uV = mV * 1000;
> > > > +
> > > > +		/* Break at the first in-range value */
> > > > +		if (min_uV <= uV && uV <= max_uV)
> > > > +			break;
> > > > +	}
> 
> > > If you are going to use a table you should implement set_voltage_sel()
> > > which will do the table walk for you, but like I say you should just be
> > > using a calculation.
> 
> > As per my understanding set_voltage_sel() is used to set a voltage if we
> > know the selector. But here it's different case, based on the min and
> > max voltages we have to identify the selector. For identifying the selector
> > we have to walk through the table. I did not find any helper functions
> > for walking through the table.
> 
> No, that would be totally unusable by anything.  If you implement _sel
> the core will do the mapping into a selector for you; if you take the
> time to look at the code you'll see that it's implementing exactly the
> above loop.
>

I got it, core part I missed and now I changed the set_voltage to
set_voltage_sel().

Thanks
AnilKumar

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/