Re: [PATCH 3/6] memcg: remove unused variable

From: Michal Hocko
Date: Tue Dec 27 2011 - 09:08:12 EST


On Sat 24-12-11 05:00:16, Kirill A. Shutemov wrote:
> From: "Kirill A. Shutemov" <kirill@xxxxxxxxxxxxx>
>
> mm/memcontrol.c: In function âmc_handle_file_pteâ:
> mm/memcontrol.c:5206:16: warning: variable âinodeâ set but not used [-Wunused-but-set-variable]
>
> Signed-off-by: Kirill A. Shutemov <kirill@xxxxxxxxxxxxx>

Looks good.
Acked-by: Michal Hocko <mhocko@xxxxxxx>

Thanks!
> ---
> mm/memcontrol.c | 2 --
> 1 files changed, 0 insertions(+), 2 deletions(-)
>
> diff --git a/mm/memcontrol.c b/mm/memcontrol.c
> index 4bac3a2..627c19e 100644
> --- a/mm/memcontrol.c
> +++ b/mm/memcontrol.c
> @@ -5203,7 +5203,6 @@ static struct page *mc_handle_file_pte(struct vm_area_struct *vma,
> unsigned long addr, pte_t ptent, swp_entry_t *entry)
> {
> struct page *page = NULL;
> - struct inode *inode;
> struct address_space *mapping;
> pgoff_t pgoff;
>
> @@ -5212,7 +5211,6 @@ static struct page *mc_handle_file_pte(struct vm_area_struct *vma,
> if (!move_file())
> return NULL;
>
> - inode = vma->vm_file->f_path.dentry->d_inode;
> mapping = vma->vm_file->f_mapping;
> if (pte_none(ptent))
> pgoff = linear_page_index(vma, addr);
> --
> 1.7.7.3
>

--
Michal Hocko
SUSE Labs
SUSE LINUX s.r.o.
Lihovarska 1060/12
190 00 Praha 9
Czech Republic
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/