Re: REGRESSION 3.2-rcX: RTC auto poweron after 5 minutes

[Andreas Friedrich]

On Mo, Dez 26, 2011 at 03:58:41 +0100, Andreas Friedrich wrote:

Hello Rabin,
...
> After shuting down my system (init 0), it powers on automatically
> after 300 seconds!
> 
> I've detected this problem the first time with the stable kernel 3.1.5.
> Bisecting leads me to the following patch:
> 
> "rtc: Disable the alarm in the hardware"
> Stable 3.1.5:     0cbc008c56f7b4a11ba6fe80e196d7ab322baabf
> Mainline 3.2-rcX: c0afabd3d553c521e003779c127143ffde55a16f
...

the 5 minutes auto-poweron problem was caused by the new function
drivers/rtc/interface.c -> rtc_alarm_disable():
   ...
   alarm.time = rtc_ktime_to_tm(ktime_add(rtc_tm_to_ktime(tm),
				        ktime_set(300, 0)));
   alarm.enabled = 0;
   ...

In this function the RTC alarm shall be disabled. Why do you set up a
5 minutes interval just before disabling the alarm?

I have changed
   ktime_set(300, 0)));
to
   ktime_set(0, 0)));
and all worked fine with my notebook.

Please check if this could be a common solution of the problem.

With best regards,
Andreas Friedrich
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/