Re: Yet another hot unplug NULL pointer dereference (was Re: statusof oops in sd_revalidate_disk?)

[Axel Theilmann]

On 12/25/2011 09:58 PM, Stefan Richter wrote:

moin,

> as far as I remember, all Linux releases in 2011 have been broken WRT hot
> removal of block devices; some more severely, some less.  Various patches
> for this went in over the year, but if they fixed anything, they always
> uncovered the next lingering unplug related bug.  The presumed first Linux

so now there are 2 known NULL-pointer problems in the cd-rom code and one in
the scsi-disk code.

Would a complete fix for this issue be a question of locating all the
possible NULL-pointers and fixing them or do you think that the hotplug
problem has to be fixed on a more "fundamental" level?

Even if there is a more fundamental problem below that has to be fixed, it
would still be nice to get in fixes for the dereferences that are currently
known to keep peoples systems from crashing.

We built a kernel with Huajun's patch included and will do some tests to see
if the problem goes away (and no others show up).


> With a little bit of bad luck, udisks-daemon or in older distros hald
> should hit the bug too.  Under kernel 3.1 I typically just got processes
> hanging in unkillable sleep.  With kernel 3.2-rc7 I get an instant kernel
> panic.

Yes, udisks is what probably triggers the bug for us. People removing USB
media before udisks is finished initializing the medium. With kernel 3.1.4
we get instant kernel panics as well.


tty, axel



-- 
Dipl.-Inform. Axel Theilmann             theilmann@xxxxxxxxxxxx
                               Tel.  (+49) 040  / 244 2407 - 13
                               Fax   (+49) 040  / 244 2407 - 24
                               Mobil (+49) 0151 / 116 18 664
PRESENSE Technologies GmbH         Sachsenstr. 5, 20097 Hamburg
                                         USt-IdNr.: DE263765024
Geschäftsführer/Managing Directors       AG Hamburg, HRB 107844
Till Dörges           Jürgen Sander              Axel Theilmann
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/