Re: [PATCH 2/2] drivers/mtd/maps/lantiq-flash.c: drop iounmap fordevm_ allocated data

[Julia Lawall]

On Tue, 27 Dec 2011, Artem Bityutskiy wrote:

> On Mon, 2011-12-26 at 18:38 +0100, Julia Lawall wrote:
> > From: Julia Lawall <julia@xxxxxxx>
> >
> > Data allocated with devm_ioremap or devm_ioremap_nocache should not be
> > freed using iounmap, because doing so causes a dangling pointer, and a
> > subsequent double free.
> >
> > The semantic match that finds this problem is as follows:
> > (http://coccinelle.lip6.fr/)
> >
> > // <smpl>
> > @r@
> > expression x;
> > @@
> > (
> >  x = devm_ioremap(...)
> > |
> >  x = devm_ioremap_nocache(...)
> > )
> >
> > @@
> > expression r.x;
> > @@
> > * iounmap(x)
> > // </smpl>
>
> Thanks Julia,
>
> surely this semantic patch script is worth adding to scripts/coccinelle?
> Are you going to take care of this?

OK, I will do that.

julia
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/