question about lqasc_release_port in drivers/tty/serial/lantiq.c

[Julia Lawall]

The function lqasc_release_port in the file drivers/tty/serial/lantiq.c is 
defined as follows:

static void
lqasc_release_port(struct uart_port *port)
{
 	if (port->flags & UPF_IOREMAP) {
        	iounmap(port->membase);
		port->membase = NULL;
	}
}

But port->membase is initialized using devm_ioremap_nocache, implying that 
it should be freed with devm_ioremap.  devm_ioremap, however, requires an 
additional &pdev->dev argument.  Maybe the call to iounmap is not needed 
at all?

julia
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/