Re: pull request: wireless 2011-12-15

From: RafaÅ MiÅecki
Date: Sun Dec 25 2011 - 18:37:42 EST


W dniu 16 grudnia 2011 07:40 uÅytkownik RafaÅ MiÅecki
<zajec5@xxxxxxxxx> napisaÅ:
> W dniu 15 grudnia 2011 22:38 uÅytkownik John W. Linville
> <linville@xxxxxxxxxxxxx> napisaÅ:
>> On Thu, Dec 15, 2011 at 09:04:29PM +0100, RafaÅ MiÅecki wrote:
>>> 2011/12/15 John W. Linville <linville@xxxxxxxxxxxxx>:
>>> > commit 42a3b63bb2ca4996a3d1210a004eae2333f1119e
>>> >
>>> > Dave,
>>> >
>>> > Here are a few more fixes intended for the 3.2 release. ÂThey are
>>> > all small and narrowly focused.
>>>
>>> John, I've made a mistake and didn't use [PATCH 3.2] header to make it
>>> clean my patch is fix. Could you take a look at
>>> [PATCH] bcma: support for suspend and resume
>>> please?
>>>
>>> It's not one-liner, but fixes lock ups, which I believe - we really
>>> want to avoid.
>>
>> It's late in the release cycle, and Dave specifically asked me to slow down.
>>
>> Are these suspend/resume lockups a regression? ÂOr have they always
>> been there? ÂDo they happen to everyone?
>
> The bug is present since first days of bcma. That's why I even decided
> to add stable to CC.
>
> Personally I've tested that only on 1 machine (I don't have more
> suspendable machines with mini PCIe slot). However all Macbook 8.1/8.2
> users have to remove b43 & bcma before suspending [0], they complain
> about that since ever.
>
> Arend: I know you're also complaining for suspend in bcma. Can you
> comment on this?
>
> [0] http://ubuntuforums.org/showthread.php?t=1695746

User nephyrin on #bcm-users has confirmed this patch fixes
suspend&resume for him. Without this patch he got deadlock without
seeing any kernel panic logs - quite an ugly case.

I still think this patch may be worth taking as fix and backporting too.

--
RafaÅ
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/