Re: [PATCH 2/2] tracing, sched: Add a new tracepoint for sleeptime
From: Arun Sharma
Date: Tue Dec 20 2011 - 13:22:56 EST
On 12/20/11 10:16 AM, Steven Rostedt wrote:
+#ifdef CREATE_TRACE_POINTS
Why the #ifdef? a static inline is fine to keep in the open. If nothing
uses it, then it just wont be used or defined.
Without the ifdef I get:
In file included from include/trace/define_trace.h:80,
from include/trace/events/sched.h:445,
from kernel/sched/core.c:86:
include/trace/events/sched.h:366: error: redefinition of
âtrace_get_sleeptimeâ
include/trace/events/sched.h:366: note: previous definition of
âtrace_get_sleeptimeâ was here
So I shamelessly copied what the other static inline function in the
file does.
I also noticed that sched_stat_sleeptime() is very similar to
sched_stat_sleep(). The latter covers sleeps but not iowait and doesn't
include the scheduler latency. Let me know if you think this is a show
stopper that needs a rename.
-Arun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/