Re: [PATCH v4 3/4] regulator: simplify twl4030 config
From: Mark Brown
Date: Mon Dec 19 2011 - 21:17:27 EST
On Tue, Dec 20, 2011 at 04:04:14AM +0200, Felipe Contreras wrote:
> On Tue, Dec 20, 2011 at 3:53 AM, Mark Brown
> > Yes, of course. Half the point in having subsystems and standard ways
> > of doing things is so that when we look at things we've got a reasonable
> > idea as to what they're supposed to be doing and people looking at the
> > code can figure out what's going on. We don't want people to have to
> > play guessing games about this stuff.
> Of course... *ideally*, but we are not there right now.
We pretty much were, but this patch has changelog which says "I've got a
cool new way of doing things for this one driver!" which clearly applies
to other drivers. I wouldn't mind a patch which does this for all MFDs
(though I really do think it should be applied to most subsystems) but
doing it for one driver isn't great.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/