Re: [PATCH] input: signedness bug in cma3000_thread_irq()

[Valdis . Kletnieks]

On Mon, 12 Dec 2011 01:49:26 EST, Xi Wang said:
> The error check (intr_status < 0) didn't work because intr_status is
> a u8.  Change its type to signed int.
>
> Signed-off-by: Xi Wang <xi.wang@xxxxxxxxx>
> ---
>  drivers/input/misc/cma3000_d0x.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/input/misc/cma3000_d0x.c b/drivers/input/misc/cma3000_d0x.c

That will fix the signed/unsigned issue.  However, was there a reason
the field was an 8-bit-wide to begin with?

Attachment: pgp00000.pgp
Description: PGP signature