Re: Is per_cpu_ptr_to_phys broken?

From: Cong Wang
Date: Wed Dec 14 2011 - 11:17:16 EST


On Wed, Dec 14, 2011 at 7:33 AM, Petr Tesarik <ptesarik@xxxxxxx> wrote:
> Hi folks,
>
...
>
> Now, the per_cpu_ptr_to_phys() function aligns all vmalloc addresses to a page
> boundary. This was probably right when Vivek Goyal introduced that function
> (commit 3b034b0d084221596bf35c8d893e1d4d5477b9cc), because per-cpu addresses
> were only allocated by vmalloc if booted with percpu_alloc=page, but this is
> no longer the case, because per-cpu variables are now always allocated that
> way AFAICS.
>
> So, shouldn't we add the offset within the page inside per_cpu_ptr_to_phys?
>

Hi,

Tejun already fixed this, see:

commit a855b84c3d8c73220d4d3cd392a7bee7c83de70e
percpu: fix chunk range calculation
author Tejun Heo <tj@xxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/