Re: [PATCH 1/3] DEBUGFS: Automatically create parents for debugfsfiles v2

From: Thomas Gleixner
Date: Tue Dec 13 2011 - 18:03:11 EST


On Tue, 13 Dec 2011, Andi Kleen wrote:

> > Hi Andi, is it possible to do say kstrdup or something instead of
>
> It's possible, just would add complexity with an additional
> error path.
>
> > variable-size array in fn[strlen(name) + 1] ? As far as I remember
> > we already had some warnings with them at least in perf land (or
> > trace land). Or I miss something?
>
> Not aware of any problems with tracing or perf. I like them at least.

That does not make them better. We had wreckage before and you can
just consult commit a84a79e4d3 and then find a good explanation why
your usage is safe.

Thanks,

tglx

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/