Re: [PATCH] AIO: Don't plug the I/O queue in do_io_submit()

From: Jeff Moyer
Date: Tue Dec 13 2011 - 17:18:55 EST


Dave Kleikamp <dave.kleikamp@xxxxxxxxxx> writes:

> Asynchronous I/O latency to a solid-state disk greatly increased
> between the 2.6.32 and 3.0 kernels. By removing the plug from
> do_io_submit(), we observed a 34% improvement in the I/O latency.
>
> Unfortunately, at this level, we don't know if the request is to
> a rotating disk or not.

I'm guessing I know the answer to this, but what workload were you
testing, and can you provide more concrete evidence than "latency
greatly increased?" Also, have you tested the effects this has when
using traditional storage for whatever your workload is? I don't feel
comfortable essentially reverting a performance patch without knowing
the entire picture. I will certainly do some testing on my end, too.

Cheers,
Jeff
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/