Re: [PATCH] omap: rx51: initialize isp1704 properly

From: Sebastian Reichel
Date: Tue Dec 13 2011 - 15:01:06 EST


On Mon, Dec 12, 2011 at 11:44:45AM -0800, Tony Lindgren wrote:
> * Felipe Contreras <felipe.contreras@xxxxxxxxx> [111208 11:52]:
> > On Thu, Dec 8, 2011 at 4:40 PM, Heikki Krogerus <krohei@xxxxxxxxx> wrote:
> > > On Wed, Dec 07, 2011 at 09:56:56PM +0200, Felipe Contreras wrote:
> > >> From: Heikki Krogerus <krohei@xxxxxxxxx>
> > >
> > > I would prefer that you change this so this is from you, like it
> > > actually is. You can mention me in the commit message if you like.
> >
> > Well, you came with the fix, I just typed it down, but as you wish :)
> >
> > >> Without this USB networking doesn't work as the link is never detected.
> > >
> > > What this changes is, it leaves the transceiver powered by default
> > > instead of setting it into power off mode. So not only USB networking
> > > is affected by this. If isp1704_charger is not enabled with RX51, USB
> > > does not work at all. Please change the comment.
> >
> > I've updated the patch.
>
> Sorry what's the deal with this one? Is this the one to use or is there
> some other patch?

I can confirm, that USB on RX51 does not work with 3.1 mainline
kernel and applying this patch (There's a v2 with fixed Author under
[0]) results in working USB support.

[0] http://www.spinics.net/lists/linux-omap/msg61217.html

-- Sebastian

Attachment: signature.asc
Description: Digital signature