Re: x2apic boot failure on recent sandy bridge system

From: Yinghai Lu
Date: Mon Dec 12 2011 - 20:25:39 EST


On Mon, Dec 12, 2011 at 3:42 PM, H. Peter Anvin <hpa@xxxxxxxxx> wrote:
> On 12/11/2011 07:40 PM, Yinghai Lu wrote:
>> -v2: use x2apic_disabled instead of nox2apic, Suggested by Thomas
>>      update x2apic_supported with x2apic_disabled, Suggested by Thomas
>
> This is ugly.  Typically we have no- for boolean options.  If we have a
> multivalue option it should be option=value, i.e. x2apic=disabled.  We
> can allow x2apic_supported as a backwards compatibility option.

x2apic_disabled is variable.

for command line, still use nox2apic for that purpose.

Thanks

Yinghai
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/