Re: [PATCH 04/11] mm: compaction: export some of the functions

From: Michal Nazarewicz
Date: Mon Dec 12 2011 - 10:46:16 EST


On Mon, 12 Dec 2011 15:29:07 +0100, Mel Gorman <mel@xxxxxxxxx> wrote:
Overall, this patch implies that CMA is always compiled in.

On Mon, Dec 12, 2011 at 03:41:04PM +0100, Michal Nazarewicz wrote:
Not really. But yes, it produces some bloat when neither CMA nor
compaction are compiled. I assume that linker will be able to deal
with that (since the functions are not EXPORT_SYMBOL'ed).

On Mon, 12 Dec 2011 16:40:15 +0100, Mel Gorman <mel@xxxxxxxxx> wrote:
The bloat exists either way. I don't believe the linker strips it out so
overall it would make more sense to depend on compaction to keep the
vmstat counters for debugging reasons if nothing else. It's not
something I feel very strongly about though.

KK, I'll do that then.

--
Best regards, _ _
.o. | Liege of Serenely Enlightened Majesty of o' \,=./ `o
..o | Computer Science, MichaÅ âmina86â Nazarewicz (o o)
ooo +----<email/xmpp: mpn@xxxxxxxxxx>--------------ooO--(_)--Ooo--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/