question about link_mem_sections()

From: Kay Sievers
Date: Mon Dec 12 2011 - 07:36:13 EST


Robin,

you added find_memory_block_hinted() with:
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux.git;a=commitdiff;h=63d027a63888e993545d10fdfe4107d543f01bca

I try to understand what's going on here, because we need to switch
away from 'struct sysdev'.

In the loop over the node data you call find_memory_block_hinted() in
a row, which might all take a reference. At the end of the section you
drop only the last reference of the iteration. The code before your
change dropped all references inside the loop.

Could you please explain the intended behaviour?

If all is right, we should at least move the now wrong comment where is belongs.

Thanks,
Kay
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/