Re: [PATCH 3/3] sound/soc/lapis: add platform driver

From: Tomoya MORINAGA
Date: Mon Dec 12 2011 - 03:28:16 EST


Searching git log,
tegra_i2s.c seems modern.
I have a question.

According to platfom.txt, describes like below.
struct snd_soc_ops {
...
};

On the other hand, tegra_i2s.c describes like below.

static const struct snd_soc_dai_ops tegra_i2s_dai_ops = {
...
};

Which is true as modern driver ? or case by case ?


>> +#define I2S_CH0_MCLK (12288000) /* Master Clock Frequency[Hz] */
> This looks like it should be board specific?
Should our platform driver use "clk_get()" ?
If no, how should our driver get the value ?

thanks in advance.

tomoya
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/