Re: [PATCH 03/06] MFD: DA9052/53 MFD core module v9 Added SPI support

From: Mark Brown
Date: Mon Dec 12 2011 - 00:01:17 EST


On Fri, Dec 09, 2011 at 07:46:33PM +0530, Ashish Jangam wrote:
> The DA9052/53 is a highly integrated PMIC subsystem with supply domain
> flexibility to support wide range of high performance application.

Reviwed-by: Mark Brown <broonie@xxxxxxxxxxxxxxxxxxxxxxxxxxx>

Looks good, though again you should've CCed Samuel. One small thing:

>
> struct device *dev;
> + struct spi_device *spi_dev;
> struct i2c_client *i2c_client;

You con't actually use this (or the i2c_client) any more so could just
drop them.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/