Re: [PATCH 3/3] kref: Remove the memory barriers

From: Peter Zijlstra
Date: Sat Dec 10 2011 - 09:59:09 EST


On Sat, 2011-12-10 at 22:07 +0800, Ming Lei wrote:
> > While true, it fails to show why this is a problem. I say it is not a
>
> IMO, the added two barriers are pairs of the implicit barrier in kref_put, so
> that we can order between kref_init/kref_get and kref_put.

Yeah so? If there's a destruction race with kref_put() the barrier won't
solve it. Other than that the actual order of get/put is irrelevant.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/