RE: [PATCH 2/2] x86, MCE: Drain mcelog buffer

From: Luck, Tony
Date: Fri Dec 09 2011 - 17:09:25 EST


> Well, off the top of my head, we could probably _not_ delete the already
> logged MCEs (bool keep arg, or similar) and when the last one registers,
> it passes keep=false and cleans them up. And since we probably know
> which one is the last - order is enforced by the initcalls order -
> we're done.

Knowing when the last one has come is hard if there are modules as well
as built-in registrants. We could save the whole list, and deliver a
copy of the history of the world so far to each as they register (never
deleting anything). But that sounds odd - why should a module loaded
6 months after system boot expect to see everything.

> However, is the platform module using MCA at all or will it probably use
> PCIe AER instead?
Don't know - its hypothetical - but it is possible that MCA might be used
for not-cpu stuff.

> Also, at the time the platform module inits, we've already regged the
> CPU decoders so we can go ahead and safely delete the logged MCEs.

I think if we ensure that the cpu decoder gets first chance to register,
we should be OK with giving it all the pended stuff. We can defer doing
something more complicated until the point that someone has a real use
case.

-Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/