Re: [patch -next] ipc/mqueue: lock() => unlock() typo

From: Serge E. Hallyn
Date: Wed Nov 30 2011 - 11:35:50 EST


Quoting Dan Carpenter (dan.carpenter@xxxxxxxxxx):
> There was a double lock typo introduced in b085f4bd6b21 "user namespace:
> make signal.c respect user namespaces"
>
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>

Jinkeys!

Acked-by: Serge Hallyn <serge@xxxxxxxxxx>

thanks very much, Dan.
-serge

> ---
> I think this patch is only needed in the -mm tree.
>
> diff --git a/ipc/mqueue.c b/ipc/mqueue.c
> index 691cfee..c246c83 100644
> --- a/ipc/mqueue.c
> +++ b/ipc/mqueue.c
> @@ -558,7 +558,7 @@ static void __do_notify(struct mqueue_inode_info *info)
> ns_of_pid(info->notify_owner));
> sig_i.si_uid = user_ns_map_uid(info->user->user_ns,
> current_cred(), current_uid());
> - rcu_read_lock();
> + rcu_read_unlock();
>
> kill_pid_info(info->notify.sigev_signo,
> &sig_i, info->notify_owner);
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/