Re: [RFC][PATCH] trimming includes from linux/security.h

From: Al Viro
Date: Wed Nov 30 2011 - 02:49:43 EST


On Wed, Nov 30, 2011 at 04:09:25PM +0900, Tetsuo Handa wrote:
> Al Viro wrote:
> > linux/security.h pulls a lot of garbage; most of it can be avoided
> > by several more struct ....; added in there,
>
> Does it make sense to create a header file that contains only "struct ....;"
> lines? A lot of "struct ....;" lines are used for avoiding compiler warning.
> This results in LXR (linux cross reference) showing like
>
> Defined as a struct type in:
>
> * security/selinux/include/avc.h, line 35

Er... Then LXR sucks. It's trivial to distinguish those from actual
definition; talks to LXR folks and let them fix their code...

struct <tag> ;

vs

struct <tag> {

is not that hard to handle, even if you bother with __attribute__ in weird
places like that. They need to distinguish those from
struct <tag> <ident>
etc., after all, so they do some amount of lookahead...
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/