Re: [PATCH] [SCSI] sd: Lower printk level for drive cache information

From: Josh Boyer
Date: Tue Nov 29 2011 - 10:03:25 EST


On Mon, Nov 28, 2011 at 11:44:42PM -0500, Christoph Hellwig wrote:
> On Mon, Nov 28, 2011 at 11:31:55AM -0500, Josh Boyer wrote:
> > Numerous devices don't present cache data, particularly USB sticks. The
> > devices operate correctly despite this, so lower the printk severity to
> > KERN_NOTICE.
>
> Do they? The last reports on the list were for devices that didn't
> present it but actually needed cache flushes despite not having the
> cache mode page.

We've seen a number of reports for liveusb images that spit out those
printks, but seem to otherwise work fine.

Even if the devices need cache flushes, what is a typical user supposed
to do about that? I'm not particularly tied to this patch, but there is
nothing a normal user can do with the information spit out by these
printks, so making it KERN_ERR seems excessive.

josh
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/