Re: [PATCH] deadlock with suspend and quotas

From: Mikulas Patocka
Date: Tue Nov 29 2011 - 07:55:03 EST


> > This is technically impossible to achieve on ext2, fat or other
> > non-transactional filesystems. These filesystems have no locks around code
> > paths that set data or inodes dirty. And you still need working sync for
> > ext2. So the best thing to do in sync is to wait until the filesystem is
> > unfrozen.
> Then suspend is effectively unsupported on the filesystem and should
> return EOPNOTSUPP? At least that's what I'd expect...
>
> Honza
> --
> Jan Kara <jack@xxxxxxx>
> SUSE Labs, CR

LVM uses suspend every time it changes layout of the logical volume. For
example when it converts to/from mirrored format, extends/shrinks the
volume, moves the volume to a different disk, takes a snapshots, merges a
snapshot back, on mirror or multipath failover.

For most of these actions (except taking a snapshot) it is irrelevant if
there are dirty data in the filesystem cache or not while it is suspended.
So there is no point in banning suspend on ext2. If you banned it, you
couldn't use ext2 on LVM at all.

Mikulas
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/