Re: [PATCH] watchdog: fix nowayout setting in s3c2410_wdt

[Wolfram Sang]

> +/* Use the following function to set the nowayout feature */
> +static inline void watchdog_set_nowayout(struct watchdog_device *wdd, int nowayout)
> +{
> +	if (nowayout)
> +		set_bit(WDOG_NO_WAY_OUT, &wdd->status);
> +}

Yes, this is better in case we might need to add something later.

> but: .status = WATCHDOG_NOWAYOUT_INIT_STATUS, is also a nice one to have.
> 
> I propose to add both options and to document them in the documentation.
> Objections anyone?

Sounds good to me.

So, I'll drop NOWAYOUT-related patches from my STMP-series?

Thanks,

   Wolfram

-- 
Pengutronix e.K.                           | Wolfram Sang                |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

Attachment: signature.asc
Description: Digital signature