Re: NULL pointer dereference in mainline and next

From: Will Deacon
Date: Tue Nov 29 2011 - 05:04:52 EST


On Mon, Nov 28, 2011 at 10:08:40PM +0000, David Miller wrote:
> From: Will Deacon <will.deacon@xxxxxxx>
> Date: Mon, 28 Nov 2011 14:35:58 +0000
>
> > On Mon, Nov 28, 2011 at 02:33:24PM +0000, Eric Dumazet wrote:
> >> Le lundi 28 novembre 2011 à 14:18 +0000, Will Deacon a écrit :
> >> > Hello,
> >> >
> >> > Commit f04565dd ("dev: use name hash for dev_seq_ops") requires a struct
> >> > dev_iter_state to be allocated for the seq_file->private member, as that is
> >> > used to implement the name hash.
> >> >
> >> > Unfortunately, the dev_mcast code wasn't updated and so only allocates space
> >> > for a seq_net_private, leading to the following NULL dereference (removed
> >> > static inline annotations to get sane backtrace):
> >
> > [...]
> >
> >> Anton Blanchard already provided a fix for this problem.
> >>
> >> http://patchwork.ozlabs.org/patch/127931/
> >
> > Ok, great - as long as it gets fixed!
>
> Please in the future report networking bugs to netdev@xxxxxxxxxxxxxxx as that
> will reach the largest number of networking developers.

Sure, I just stumbled across this testing some ARM stuff, but I'll bear that
in mind in future.

Cheers,

Will
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/