Re: Re: [PATCH 2/2] misc: add driver support for MAX8997 MUIC

[MyungJoo Ham]

Sender : Andrew Morton<akpm@xxxxxxxxxxxxxxxxxxxx>
Date : 2011-11-29 08:48 (GMT+09:00)
Title : Re: [PATCH 2/2] misc: add driver support for MAX8997 MUIC
> 
> On Thu, 24 Nov 2011 18:12:18 +0900
> Donggeun Kim wrote:
> >
> > ...
> >
> > +static irqreturn_t max8997_muic_irq_handler(int irq, void *data)
> > +{
> > + struct max8997_muic_info *info = data;
> > +
> > + dev_dbg(info->dev, "irq:%d ", irq);
> > + info->irq = irq;
> > +
> > + schedule_work(&info->irq_work);
> > +
> > + return IRQ_HANDLED;
> > +}
> 
> The code does schedule_work() but I see no flush_work().  Is it
> possible for the work to still be pending after device shutdown, or
> even after rmmod?
> 

Yes, it is possible that the work is still pending or running and use data that are freed by max8997_muic_remove().

To be safe with the last-minute interrupt handling, we may need to add flush_work or cancel_work_sync at max8997_muic_remove().

> 

 MyungJoo Ham (함명주)

Mobile Software Platform Lab,
Digital Media and Communications (DMC) Business
Samsung Electronics
cell: +82-10-6714-2858 / office: +82-31-279-8033
N떑꿩ěr¸›y鉉싕b˛XФ푤vŘ^–)頻{.nÇ+돴ĽŠ{ą묎çzX㎍썳變}Š옽Ć zÚ&j:+v돣žŤ묎çzZ+€Ę+zf＂ˇhš닱~넮녬i˙鎬zšŽwⅱ¸?솳鈺Ú&˘)刪f뷌^j푹y§m끷@AŤa뛴˙0띠hŽĺ’i