Re: [PATCH 3/5] uprobes: introduce uprobe_xol_slots[NR_CPUS]

From: Peter Zijlstra
Date: Mon Nov 28 2011 - 14:49:09 EST


On Mon, 2011-11-28 at 20:07 +0100, Oleg Nesterov wrote:
> + UPROBE_XOL_FIRST_PAGE = UPROBE_XOL_LAST_PAGE
> + + NR_CPUS * UPROBES_XOL_SLOT_BYTES / PAGE_SIZE,

I think that wants to be:
+ DIV_ROUND_UP(NR_CPUS * UPROBES_XOL_SLOT_BYTES, PAGE_SIZE);

otherwise you'll end up with 0 pages for UP and the sort.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/