Re: [PATCH 10/62] ata: remove the second argument ofk[un]map_atomic()

From: James Bottomley
Date: Mon Nov 28 2011 - 14:00:18 EST


On Mon, 2011-11-28 at 19:49 +0800, Cong Wang wrote:
> ä 2011å11æ28æ 19:42, Cong Wang åé:
> > ä 2011å11æ28æ 18:01, Sergei Shtylyov åé:
> >> Hello.
> >>
> >> On 27-11-2011 9:26, Cong Wang wrote:
> >>
> >>> Signed-off-by: Cong Wang<amwang@xxxxxxxxxx>
> >>> ---
> >>> drivers/ata/libata-sff.c | 8 ++++----
> >>> 1 files changed, 4 insertions(+), 4 deletions(-)
> >>
> >> IMO, you should do this in a single patch, not piecemeal to keep the kernel bisectable.
> >>
> >
> > Hi,
> >
> > Please see patch 01/62,
> >
> > https://lkml.org/lkml/2011/11/28/35
> >
> > So even without it, the kernel can still compile, just with some warnings.
> >
>
> Ah, no, sorry that I replied too quickly. We have to have at least 01/62
> to compile.
>
> Actually I did make the patches as a whole, but Andrew Morton prefers to
> split them, so I make V2 of them.

I'd vote for as a whole as well, but if there's some legitimate reason
why not, then take them through Jiri's trivial tree; it's pretty trivial
anyway and at least going that way would keep them bisectable.

James


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/