Re: [PATCH v2] sound/soc/codecs: add LAPIS Semiconductor ML26124

From: Mark Brown
Date: Mon Nov 28 2011 - 06:34:59 EST


On Mon, Nov 28, 2011 at 06:44:04PM +0900, Tomoya MORINAGA wrote:
> 2011/11/25 Mark Brown <broonie@xxxxxxxxxxxxxxxxxxxxxxxxxxx>: wrote

> >> +     SOC_SINGLE("Digital Volume Switch", ML26124_FILTER_EN, 4, 1, 0),

> > This needs either a Playback or Capture in there to match up with the
> > above unless it genuinely does mute both which would be really weird.

> Digital Volume Switch is used for both Playback and Capture.

That's *really* odd. If that is the case it should probably just be
"Digital Switch" - having both Volume and Switch doesn't make any sense.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/