Re: [PATCH] video: convert drivers/video/* to use module_platform_driver()

From: Alexey Charkov
Date: Mon Nov 28 2011 - 04:55:22 EST

Next message: Eric Dumazet: "Re: [PATCH] net: Fix corruption in /proc/*/net/dev_mcast"
Previous message: Tomoya MORINAGA: "Re: [PATCH v2] sound/soc/codecs: add LAPIS Semiconductor ML26124"
In reply to: Damian Hobson-Garcia: "Re: [PATCH] video: convert drivers/video/* to use module_platform_driver()"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

2011/11/26 Axel Lin <axel.lin@xxxxxxxxx>:
> This patch converts the drivers in drivers/video/* to use the
> module_platform_driver() macro which makes the code smaller and a bit
> simpler.
>
> Cc: Wan ZongShun <mcuos.com@xxxxxxxxx>
> Cc: Sascha Hauer <s.hauer@xxxxxxxxxxxxxx>
> Cc: Lennert Buytenhek <buytenh@xxxxxxxxxxx>
> Cc: Ben Dooks <ben@xxxxxxxxxxxx>
> Cc: Alexey Charkov <alchark@xxxxxxxxx>
> Cc: Damian Hobson-Garcia <dhobsong@xxxxxxxxxx>
> Cc: Manuel Lauss <mano@xxxxxxxxxxxxxxxxxxxxxxx>
> Signed-off-by: Axel Lin <axel.lin@xxxxxxxxx>
> ---
> Âdrivers/video/mxsfb.c Â Â Â Â Â Â| Â 13 +------------
> Âdrivers/video/nuc900fb.c Â Â Â Â | Â 13 +------------
> Âdrivers/video/pxa168fb.c Â Â Â Â | Â 12 +-----------
> Âdrivers/video/pxa3xx-gcu.c Â Â Â | Â 15 +--------------
> Âdrivers/video/s3c-fb.c Â Â Â Â Â | Â 13 +------------
> Âdrivers/video/sh7760fb.c Â Â Â Â | Â 13 +------------
> Âdrivers/video/sh_mobile_lcdcfb.c | Â 13 +------------
> Âdrivers/video/sh_mobile_meram.c Â| Â 13 +------------
> Âdrivers/video/sm501fb.c Â Â Â Â Â| Â 13 +------------
> Âdrivers/video/vt8500lcdfb.c Â Â Â| Â 13 +------------
> Âdrivers/video/w100fb.c Â Â Â Â Â | Â 13 +------------
> Âdrivers/video/wm8505fb.c Â Â Â Â | Â 13 +------------
> Âdrivers/video/wmt_ge_rops.c Â Â Â| Â 13 +------------
> Âdrivers/video/xilinxfb.c Â Â Â Â | Â 20 +-------------------
> Â14 files changed, 14 insertions(+), 176 deletions(-)
>
> diff --git a/drivers/video/mxsfb.c b/drivers/video/mxsfb.c
> index d837d63..18742c2 100644
> --- a/drivers/video/mxsfb.c
> +++ b/drivers/video/mxsfb.c
> @@ -902,18 +902,7 @@ static struct platform_driver mxsfb_driver = {
> Â Â Â Â},
> Â};
>
> -static int __init mxsfb_init(void)
> -{
> - Â Â Â return platform_driver_register(&mxsfb_driver);
> -}
> -
> -static void __exit mxsfb_exit(void)
> -{
> - Â Â Â platform_driver_unregister(&mxsfb_driver);
> -}
> -
> -module_init(mxsfb_init);
> -module_exit(mxsfb_exit);
> +module_platform_driver(mxsfb_devtype);

Shouldn't this one have 'mxsfb_driver' as the argument instead?

>
> ÂMODULE_DESCRIPTION("Freescale mxs framebuffer driver");
> ÂMODULE_AUTHOR("Sascha Hauer, Pengutronix");
> diff --git a/drivers/video/nuc900fb.c b/drivers/video/nuc900fb.c
> index d1fbbd8..e10f551 100644
> --- a/drivers/video/nuc900fb.c
> +++ b/drivers/video/nuc900fb.c
> @@ -762,18 +762,7 @@ static struct platform_driver nuc900fb_driver = {
> Â Â Â Â},
> Â};
>
> -int __devinit nuc900fb_init(void)
> -{
> - Â Â Â return platform_driver_register(&nuc900fb_driver);
> -}
> -
> -static void __exit nuc900fb_cleanup(void)
> -{
> - Â Â Â platform_driver_unregister(&nuc900fb_driver);
> -}
> -
> -module_init(nuc900fb_init);
> -module_exit(nuc900fb_cleanup);
> +module_platform_driver(nuc900fb_driver);
>
> ÂMODULE_DESCRIPTION("Framebuffer driver for the NUC900");
> ÂMODULE_LICENSE("GPL");
> diff --git a/drivers/video/pxa168fb.c b/drivers/video/pxa168fb.c
> index 18ead6f..8384b94 100644
> --- a/drivers/video/pxa168fb.c
> +++ b/drivers/video/pxa168fb.c
> @@ -832,17 +832,7 @@ static struct platform_driver pxa168fb_driver = {
> Â Â Â Â.remove Â Â Â Â = __devexit_p(pxa168fb_remove),
> Â};
>
> -static int __init pxa168fb_init(void)
> -{
> - Â Â Â return platform_driver_register(&pxa168fb_driver);
> -}
> -module_init(pxa168fb_init);
> -
> -static void __exit pxa168fb_exit(void)
> -{
> - Â Â Â platform_driver_unregister(&pxa168fb_driver);
> -}
> -module_exit(pxa168fb_exit);
> +module_platform_driver(pxa168fb_driver);
>
> ÂMODULE_AUTHOR("Lennert Buytenhek <buytenh@xxxxxxxxxxx> "
> Â Â Â Â Â Â Â"Green Wan <gwan@xxxxxxxxxxx>");
> diff --git a/drivers/video/pxa3xx-gcu.c b/drivers/video/pxa3xx-gcu.c
> index 1ed8b36..1d71c08 100644
> --- a/drivers/video/pxa3xx-gcu.c
> +++ b/drivers/video/pxa3xx-gcu.c
> @@ -747,20 +747,7 @@ static struct platform_driver pxa3xx_gcu_driver = {
> Â Â Â Â},
> Â};
>
> -static int __init
> -pxa3xx_gcu_init(void)
> -{
> - Â Â Â return platform_driver_register(&pxa3xx_gcu_driver);
> -}
> -
> -static void __exit
> -pxa3xx_gcu_exit(void)
> -{
> - Â Â Â platform_driver_unregister(&pxa3xx_gcu_driver);
> -}
> -
> -module_init(pxa3xx_gcu_init);
> -module_exit(pxa3xx_gcu_exit);
> +module_platform_driver(pxa3xx_gcu_driver);
>
> ÂMODULE_DESCRIPTION("PXA3xx graphics controller unit driver");
> ÂMODULE_LICENSE("GPL");
> diff --git a/drivers/video/s3c-fb.c b/drivers/video/s3c-fb.c
> index 12eaee0..cf1d11f 100644
> --- a/drivers/video/s3c-fb.c
> +++ b/drivers/video/s3c-fb.c
> @@ -2003,18 +2003,7 @@ static struct platform_driver s3c_fb_driver = {
> Â Â Â Â},
> Â};
>
> -static int __init s3c_fb_init(void)
> -{
> - Â Â Â return platform_driver_register(&s3c_fb_driver);
> -}
> -
> -static void __exit s3c_fb_cleanup(void)
> -{
> - Â Â Â platform_driver_unregister(&s3c_fb_driver);
> -}
> -
> -module_init(s3c_fb_init);
> -module_exit(s3c_fb_cleanup);
> +module_platform_driver(s3c_fb_driver);
>
> ÂMODULE_AUTHOR("Ben Dooks <ben@xxxxxxxxxxxx>");
> ÂMODULE_DESCRIPTION("Samsung S3C SoC Framebuffer driver");
> diff --git a/drivers/video/sh7760fb.c b/drivers/video/sh7760fb.c
> index 45e47d8..83b16e2 100644
> --- a/drivers/video/sh7760fb.c
> +++ b/drivers/video/sh7760fb.c
> @@ -585,18 +585,7 @@ static struct platform_driver sh7760_lcdc_driver = {
> Â Â Â Â.remove = __devexit_p(sh7760fb_remove),
> Â};
>
> -static int __init sh7760fb_init(void)
> -{
> - Â Â Â return platform_driver_register(&sh7760_lcdc_driver);
> -}
> -
> -static void __exit sh7760fb_exit(void)
> -{
> - Â Â Â platform_driver_unregister(&sh7760_lcdc_driver);
> -}
> -
> -module_init(sh7760fb_init);
> -module_exit(sh7760fb_exit);
> +module_platform_driver(sh7760_lcdc_driver);
>
> ÂMODULE_AUTHOR("Nobuhiro Iwamatsu, Manuel Lauss");
> ÂMODULE_DESCRIPTION("FBdev for SH7760/63 integrated LCD Controller");
> diff --git a/drivers/video/sh_mobile_lcdcfb.c b/drivers/video/sh_mobile_lcdcfb.c
> index 1f49ab4..a264ebf 100644
> --- a/drivers/video/sh_mobile_lcdcfb.c
> +++ b/drivers/video/sh_mobile_lcdcfb.c
> @@ -1709,18 +1709,7 @@ static struct platform_driver sh_mobile_lcdc_driver = {
> Â Â Â Â.remove Â Â Â Â = sh_mobile_lcdc_remove,
> Â};
>
> -static int __init sh_mobile_lcdc_init(void)
> -{
> - Â Â Â return platform_driver_register(&sh_mobile_lcdc_driver);
> -}
> -
> -static void __exit sh_mobile_lcdc_exit(void)
> -{
> - Â Â Â platform_driver_unregister(&sh_mobile_lcdc_driver);
> -}
> -
> -module_init(sh_mobile_lcdc_init);
> -module_exit(sh_mobile_lcdc_exit);
> +module_platform_driver(sh_mobile_lcdc_driver);
>
> ÂMODULE_DESCRIPTION("SuperH Mobile LCDC Framebuffer driver");
> ÂMODULE_AUTHOR("Magnus Damm <damm@xxxxxxxxxxxxx>");
> diff --git a/drivers/video/sh_mobile_meram.c b/drivers/video/sh_mobile_meram.c
> index 4d63490..f45d83e 100644
> --- a/drivers/video/sh_mobile_meram.c
> +++ b/drivers/video/sh_mobile_meram.c
> @@ -679,18 +679,7 @@ static struct platform_driver sh_mobile_meram_driver = {
> Â Â Â Â.remove Â Â Â Â = sh_mobile_meram_remove,
> Â};
>
> -static int __init sh_mobile_meram_init(void)
> -{
> - Â Â Â return platform_driver_register(&sh_mobile_meram_driver);
> -}
> -
> -static void __exit sh_mobile_meram_exit(void)
> -{
> - Â Â Â platform_driver_unregister(&sh_mobile_meram_driver);
> -}
> -
> -module_init(sh_mobile_meram_init);
> -module_exit(sh_mobile_meram_exit);
> +module_platform_driver(sh_mobile_meram_driver);
>
> ÂMODULE_DESCRIPTION("SuperH Mobile MERAM driver");
> ÂMODULE_AUTHOR("Damian Hobson-Garcia / Takanari Hayama");
> diff --git a/drivers/video/sm501fb.c b/drivers/video/sm501fb.c
> index a78254c..3690eff 100644
> --- a/drivers/video/sm501fb.c
> +++ b/drivers/video/sm501fb.c
> @@ -2230,18 +2230,7 @@ static struct platform_driver sm501fb_driver = {
> Â Â Â Â},
> Â};
>
> -static int __devinit sm501fb_init(void)
> -{
> - Â Â Â return platform_driver_register(&sm501fb_driver);
> -}
> -
> -static void __exit sm501fb_cleanup(void)
> -{
> - Â Â Â platform_driver_unregister(&sm501fb_driver);
> -}
> -
> -module_init(sm501fb_init);
> -module_exit(sm501fb_cleanup);
> +module_platform_driver(sm501fb_driver);
>
> Âmodule_param_named(mode, fb_mode, charp, 0);
> ÂMODULE_PARM_DESC(mode,
> diff --git a/drivers/video/vt8500lcdfb.c b/drivers/video/vt8500lcdfb.c
> index 777c21d..2a5fe6e 100644
> --- a/drivers/video/vt8500lcdfb.c
> +++ b/drivers/video/vt8500lcdfb.c
> @@ -457,18 +457,7 @@ static struct platform_driver vt8500lcd_driver = {
> Â Â Â Â},
> Â};
>
> -static int __init vt8500lcd_init(void)
> -{
> - Â Â Â return platform_driver_register(&vt8500lcd_driver);
> -}
> -
> -static void __exit vt8500lcd_exit(void)
> -{
> - Â Â Â platform_driver_unregister(&vt8500lcd_driver);
> -}
> -
> -module_init(vt8500lcd_init);
> -module_exit(vt8500lcd_exit);
> +module_platform_driver(vt8500lcd_driver);
>
> ÂMODULE_AUTHOR("Alexey Charkov <alchark@xxxxxxxxx>");
> ÂMODULE_DESCRIPTION("LCD controller driver for VIA VT8500");
> diff --git a/drivers/video/w100fb.c b/drivers/video/w100fb.c
> index 2375e5b..90a2e30 100644
> --- a/drivers/video/w100fb.c
> +++ b/drivers/video/w100fb.c
> @@ -1620,18 +1620,7 @@ static struct platform_driver w100fb_driver = {
> Â Â Â Â},
> Â};
>
> -int __init w100fb_init(void)
> -{
> - Â Â Â return platform_driver_register(&w100fb_driver);
> -}
> -
> -void __exit w100fb_cleanup(void)
> -{
> - Â Â Â platform_driver_unregister(&w100fb_driver);
> -}
> -
> -module_init(w100fb_init);
> -module_exit(w100fb_cleanup);
> +module_platform_driver(w100fb_driver);
>
> ÂMODULE_DESCRIPTION("ATI Imageon w100 framebuffer driver");
> ÂMODULE_LICENSE("GPL");
> diff --git a/drivers/video/wm8505fb.c b/drivers/video/wm8505fb.c
> index 96e34a5..c8703bd 100644
> --- a/drivers/video/wm8505fb.c
> +++ b/drivers/video/wm8505fb.c
> @@ -404,18 +404,7 @@ static struct platform_driver wm8505fb_driver = {
> Â Â Â Â},
> Â};
>
> -static int __init wm8505fb_init(void)
> -{
> - Â Â Â return platform_driver_register(&wm8505fb_driver);
> -}
> -
> -static void __exit wm8505fb_exit(void)
> -{
> - Â Â Â platform_driver_unregister(&wm8505fb_driver);
> -}
> -
> -module_init(wm8505fb_init);
> -module_exit(wm8505fb_exit);
> +module_platform_driver(wm8505fb_driver);
>
> ÂMODULE_AUTHOR("Ed Spiridonov <edo.rus@xxxxxxxxx>");
> ÂMODULE_DESCRIPTION("Framebuffer driver for WMT WM8505");
> diff --git a/drivers/video/wmt_ge_rops.c b/drivers/video/wmt_ge_rops.c
> index 45832b7..55be386 100644
> --- a/drivers/video/wmt_ge_rops.c
> +++ b/drivers/video/wmt_ge_rops.c
> @@ -167,18 +167,7 @@ static struct platform_driver wmt_ge_rops_driver = {
> Â Â Â Â},
> Â};
>
> -static int __init wmt_ge_rops_init(void)
> -{
> - Â Â Â return platform_driver_register(&wmt_ge_rops_driver);
> -}
> -
> -static void __exit wmt_ge_rops_exit(void)
> -{
> - Â Â Â platform_driver_unregister(&wmt_ge_rops_driver);
> -}
> -
> -module_init(wmt_ge_rops_init);
> -module_exit(wmt_ge_rops_exit);
> +module_platform_driver(wmt_ge_rops_driver);
>
> ÂMODULE_AUTHOR("Alexey Charkov <alchark@xxxxxxxxx");
> ÂMODULE_DESCRIPTION("Accelerators for raster operations using "

For vt8500lcdfb, wm8505fb and wmt_ge_rops:

Acked-by: Alexey Charkov <alchark@xxxxxxxxx>

Thanks,
Alexey

> diff --git a/drivers/video/xilinxfb.c b/drivers/video/xilinxfb.c
> index fcb6cd9..1808452 100644
> --- a/drivers/video/xilinxfb.c
> +++ b/drivers/video/xilinxfb.c
> @@ -511,25 +511,7 @@ static struct platform_driver xilinxfb_of_driver = {
> Â Â Â Â},
> Â};
>
> -
> -/* ---------------------------------------------------------------------
> - * Module setup and teardown
> - */
> -
> -static int __init
> -xilinxfb_init(void)
> -{
> - Â Â Â return platform_driver_register(&xilinxfb_of_driver);
> -}
> -
> -static void __exit
> -xilinxfb_cleanup(void)
> -{
> - Â Â Â platform_driver_unregister(&xilinxfb_of_driver);
> -}
> -
> -module_init(xilinxfb_init);
> -module_exit(xilinxfb_cleanup);
> +module_platform_driver(xilinxfb_of_driver);
>
> ÂMODULE_AUTHOR("MontaVista Software, Inc. <source@xxxxxxxxxx>");
> ÂMODULE_DESCRIPTION("Xilinx TFT frame buffer driver");
> --
> 1.7.5.4
>
>
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Next message: Eric Dumazet: "Re: [PATCH] net: Fix corruption in /proc/*/net/dev_mcast"
Previous message: Tomoya MORINAGA: "Re: [PATCH v2] sound/soc/codecs: add LAPIS Semiconductor ML26124"
In reply to: Damian Hobson-Garcia: "Re: [PATCH] video: convert drivers/video/* to use module_platform_driver()"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]